Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt](nereids) do not throw exception in fold const rule #49802

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

englefly
Copy link
Contributor

@englefly englefly commented Apr 3, 2025

What problem does this PR solve?

cost fold rule may throw some exceptions. if feDebug=false, the exceptions will be ignored, and the rule returns the original expression.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Apr 3, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@englefly englefly marked this pull request as draft April 3, 2025 10:01
@englefly
Copy link
Contributor Author

englefly commented Apr 7, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34532 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 72a88630ead931577823eb22d8d6e837d1daa4bd, data reload: false

------ Round 1 ----------------------------------
q1	25813	5073	5122	5073
q2	2061	275	179	179
q3	10393	1241	695	695
q4	10687	982	527	527
q5	9173	2306	2392	2306
q6	191	173	140	140
q7	894	753	632	632
q8	9316	1321	1064	1064
q9	7587	5143	5183	5143
q10	6867	2326	1900	1900
q11	495	282	266	266
q12	350	353	215	215
q13	17879	3937	3355	3355
q14	249	242	230	230
q15	550	514	506	506
q16	889	628	606	606
q17	917	857	372	372
q18	9903	7388	7107	7107
q19	2245	951	559	559
q20	346	327	234	234
q21	4180	3303	2445	2445
q22	1034	1028	978	978
Total cold run time: 122019 ms
Total hot run time: 34532 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5261	5053	5150	5053
q2	241	333	235	235
q3	2115	2683	2393	2393
q4	1492	1876	1479	1479
q5	4471	4357	4342	4342
q6	221	171	130	130
q7	1957	1895	1827	1827
q8	2626	2621	2547	2547
q9	7148	7300	7108	7108
q10	2949	3154	2739	2739
q11	583	529	484	484
q12	678	765	578	578
q13	3539	4040	3310	3310
q14	277	312	269	269
q15	510	485	491	485
q16	654	694	657	657
q17	1148	1536	1352	1352
q18	7693	7545	7388	7388
q19	776	776	968	776
q20	2071	2023	1875	1875
q21	5313	4890	4772	4772
q22	1109	1038	1006	1006
Total cold run time: 52832 ms
Total hot run time: 50805 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193369 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 72a88630ead931577823eb22d8d6e837d1daa4bd, data reload: false

query1	1409	1030	1010	1010
query2	6222	1984	1916	1916
query3	10995	4426	4467	4426
query4	57563	24803	22853	22853
query5	4759	507	469	469
query6	370	224	217	217
query7	4955	501	278	278
query8	339	243	243	243
query9	6358	2593	2631	2593
query10	430	333	255	255
query11	14976	14963	14840	14840
query12	166	111	109	109
query13	1103	515	392	392
query14	10164	6443	6404	6404
query15	214	200	187	187
query16	7059	635	510	510
query17	1098	725	594	594
query18	1579	415	316	316
query19	191	181	162	162
query20	121	116	113	113
query21	212	127	108	108
query22	4591	4659	4635	4635
query23	33848	33413	33630	33413
query24	6664	2461	2445	2445
query25	475	463	447	447
query26	669	271	152	152
query27	2211	514	334	334
query28	3120	2477	2440	2440
query29	606	570	429	429
query30	281	221	197	197
query31	883	858	785	785
query32	73	64	65	64
query33	439	355	300	300
query34	771	876	544	544
query35	829	853	765	765
query36	961	997	897	897
query37	118	101	75	75
query38	4246	4228	4191	4191
query39	1507	1443	1492	1443
query40	223	125	108	108
query41	54	54	51	51
query42	135	118	115	115
query43	501	513	497	497
query44	1316	841	816	816
query45	176	173	167	167
query46	854	1047	651	651
query47	1888	1934	1860	1860
query48	381	412	310	310
query49	704	496	413	413
query50	679	721	415	415
query51	4247	4277	4269	4269
query52	121	105	105	105
query53	244	272	183	183
query54	577	595	505	505
query55	84	84	81	81
query56	321	289	328	289
query57	1182	1194	1174	1174
query58	298	262	253	253
query59	2852	2830	2653	2653
query60	328	313	306	306
query61	147	121	123	121
query62	725	733	658	658
query63	222	186	186	186
query64	1461	1011	688	688
query65	4280	4222	4196	4196
query66	713	424	320	320
query67	16369	15706	15421	15421
query68	5559	851	533	533
query69	565	320	298	298
query70	1165	1072	1105	1072
query71	450	334	301	301
query72	6147	4933	5000	4933
query73	1216	726	348	348
query74	8822	9200	8796	8796
query75	3482	3254	2718	2718
query76	3880	1191	752	752
query77	559	373	281	281
query78	10105	10018	9304	9304
query79	3014	827	568	568
query80	973	499	529	499
query81	511	260	216	216
query82	727	126	102	102
query83	416	243	233	233
query84	292	110	86	86
query85	787	355	314	314
query86	445	305	279	279
query87	4480	4479	4382	4382
query88	3673	2259	2254	2254
query89	407	312	279	279
query90	1838	214	214	214
query91	145	145	111	111
query92	80	61	58	58
query93	2834	930	580	580
query94	701	425	305	305
query95	368	300	294	294
query96	483	577	276	276
query97	3261	3239	3125	3125
query98	233	210	197	197
query99	1433	1390	1299	1299
Total cold run time: 302708 ms
Total hot run time: 193369 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.18 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 72a88630ead931577823eb22d8d6e837d1daa4bd, data reload: false

query1	0.03	0.04	0.02
query2	0.12	0.11	0.10
query3	0.25	0.19	0.19
query4	1.60	0.19	0.20
query5	0.60	0.58	0.58
query6	1.20	0.72	0.71
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.58	0.52	0.51
query10	0.57	0.60	0.57
query11	0.16	0.10	0.10
query12	0.15	0.11	0.12
query13	0.62	0.60	0.60
query14	2.66	2.70	2.67
query15	0.92	0.86	0.84
query16	0.38	0.37	0.39
query17	1.04	1.00	1.04
query18	0.20	0.20	0.19
query19	1.87	1.85	1.90
query20	0.02	0.01	0.01
query21	15.38	0.90	0.54
query22	0.75	1.19	0.70
query23	14.87	1.42	0.61
query24	6.84	1.08	0.84
query25	0.46	0.14	0.13
query26	0.66	0.17	0.14
query27	0.05	0.05	0.05
query28	9.70	0.85	0.44
query29	12.55	4.00	3.35
query30	0.25	0.10	0.06
query31	2.82	0.58	0.38
query32	3.22	0.55	0.47
query33	3.03	3.14	3.04
query34	15.79	5.15	4.51
query35	4.50	4.54	4.47
query36	0.67	0.50	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.03
query40	0.16	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 105.05 s
Total hot run time: 31.18 s

@englefly
Copy link
Contributor Author

englefly commented Apr 8, 2025

run cloud_p0

@englefly englefly self-assigned this Apr 8, 2025
@englefly englefly marked this pull request as ready for review April 8, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants