Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Upgrade sidepanel extension to JupyterLab 4.x compatibility [DO NOT MERGE] #34495

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Chenzo1001
Copy link

@Chenzo1001 Chenzo1001 commented Apr 1, 2025

Updated all @jupyterlab/* dependencies to v4.x
Adapted to breaking API changes (SessionContext, TypeScript types, etc.)
Fixed strict type checking errors introduced in TS 4.x
Requires Node 16+ and updated dependencies
Upgrade to React 18+


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Chenzo1001 Chenzo1001 changed the title ✨ Upgrade extension to JupyterLab 4.x compatibility ✨ Upgrade sidepanel extension to JupyterLab 4.x compatibility Apr 1, 2025
@Chenzo1001 Chenzo1001 marked this pull request as ready for review April 1, 2025 14:05
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@liferoad liferoad requested a review from nika-qubit April 1, 2025 15:48
@liferoad
Copy link
Contributor

liferoad commented Apr 1, 2025

Does this still work with 3.x? we will need to release this later as well.

@Chenzo1001
Copy link
Author

Does this still work with 3.x? we will need to release this later as well.

I build it with 3.x and it failed. Because the version of @jupyterlab/builder can't be compatible between 3.x and 4.x. I can rename these files to *.v3.js and *.v4.js, then add scripts to select the builder version. But I think maybe switch to 4.x is a better choice. 😁

Copy link
Contributor

github-actions bot commented Apr 1, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@nika-qubit nika-qubit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, looks like this is causing precommit failures, could you please take a look? https://github.com/apache/beam/actions/runs/14197749402/job/39777121469

@liferoad liferoad changed the title ✨ Upgrade sidepanel extension to JupyterLab 4.x compatibility ✨ Upgrade sidepanel extension to JupyterLab 4.x compatibility [DO NOT MERGE] Apr 1, 2025
@liferoad
Copy link
Contributor

liferoad commented Apr 1, 2025

Do not merge this PR. Please wait for me to LGTM.

@Chenzo1001
Copy link
Author

Actually, looks like this is causing precommit failures, could you please take a look? https://github.com/apache/beam/actions/runs/14197749402/job/39777121469

The testsuites and CI scripts are also needed to be upgrade. I'll commit my changes later this day.

@github-actions github-actions bot added build and removed build labels Apr 3, 2025
@github-actions github-actions bot added build and removed build labels Apr 3, 2025
@github-actions github-actions bot removed the build label Apr 3, 2025
@github-actions github-actions bot added the build label Apr 3, 2025
@github-actions github-actions bot added build and removed build labels Apr 3, 2025
@Chenzo1001 Chenzo1001 requested a review from damccorm April 3, 2025 05:35
@Chenzo1001
Copy link
Author

Chenzo1001 commented Apr 3, 2025

@liferoad @damccorm Hi I've finished updating packages. Please review my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants