Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with latest iio events #1268

Merged
merged 4 commits into from
Apr 8, 2025
Merged

Conversation

dNechita
Copy link
Contributor

@dNechita dNechita commented Apr 3, 2025

PR Description

Update C, C#, Python to include the new:

  • IIO event type: IIO_EV_TYPE_FAULT
  • IIO event direction: IIO_EV_DIR_FAULT_OPENWIRE

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have commented new code, particulary complex or unclear areas
  • I have checked that I did not intoduced new warnings or errors (CI output)
  • I have checked that components that use libiio did not get broken
  • I have updated the documentation accordingly (GitHub Pages, READMEs, etc)

@rgetz
Copy link
Contributor

rgetz commented Apr 3, 2025

For traceability - we normally include the reference to the kernel git that includes the required change...

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/include/uapi/linux/iio/types.h?id=34934d79965518548d33c0513a9572ae936d8c29

or torvalds/linux@34934d7

your preference.

@rgetz
Copy link
Contributor

rgetz commented Apr 3, 2025

and I think you are missing a update to utils/iio_event.c:iio_ev_type_text[] and utils/iio_event.c:iio_ev_dir_text[] - that's not looked at in the script yet. (something else to add if you want)...

@dNechita dNechita force-pushed the sync-with-latest-iio-events branch from 7afeab9 to d599e17 Compare April 3, 2025 21:26
@dNechita
Copy link
Contributor Author

dNechita commented Apr 3, 2025

and I think you are missing a update to utils/iio_event.c:iio_ev_type_text[] and utils/iio_event.c:iio_ev_dir_text[] - that's not looked at in the script yet. (something else to add if you want)...

It looks that way, yes. I wasn't aware of it. Thanks!

@rgetz
Copy link
Contributor

rgetz commented Apr 4, 2025

Sorry - what is #1269 and this one? (Looks like they are dups?)

@dNechita
Copy link
Contributor Author

dNechita commented Apr 7, 2025

Sorry - what is #1269 and this one? (Looks like they are dups?)

This PR is targeting libiio v1 while PR 1269 is targeting libiio v0.

@rgetz
Copy link
Contributor

rgetz commented Apr 7, 2025

It looks that way, yes. I wasn't aware of it. Thanks!

should those strings go into iio.h, or somewhere else (inside event.c - similar to channel.c - so it can be passed to an app in a libiio function) so applications don't need to maintain them themselves?

Copy link
Contributor

@rgetz rgetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - looks great.

@cristina-suteu cristina-suteu merged commit 29d1663 into main Apr 8, 2025
21 of 24 checks passed
@cristina-suteu cristina-suteu deleted the sync-with-latest-iio-events branch April 8, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants