Add $ as a surround character (#8895)
#9525
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds
$as a "quote"-like character to support surround and bracket-like actions (e.g.yi$,ysi$}). These actions are supported by vim surround, so users expect this to line up when interacting with VSCodeVim.Which issue(s) this PR fixes
Fixes #8895
Special notes for your reviewer:
This creates a weird mismatch between the names for
Quotebehavior, since it now supports a$. The naming for "quotes" makes sense given things likediq, but I think in essense the quote matching really lines up with a "directionless" behavior.