Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add defaultText to options.networking.stevenBlackHosts.enableIPv6 #2848

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add defaultText to options.networking.stevenBlackHosts.enableIPv6 #2848

wants to merge 1 commit into from

Conversation

Pandapip1
Copy link
Contributor

@Pandapip1 Pandapip1 commented Mar 27, 2025 •
edited
Loading

Fixes #2828

Closes #2847 (Supersedes)

@Pandapip1
Copy link
Contributor Author

CC @benjamb, @toastal

@Pandapip1
Copy link
Contributor Author

Whoops looks like lib isn't defined. Lemme draft this for now.

@Pandapip1 Pandapip1 marked this pull request as draft March 27, 2025 18:24
@Pandapip1 Pandapip1 marked this pull request as ready for review March 27, 2025 18:27
@Pandapip1
Copy link
Contributor Author

Pandapip1 commented Mar 27, 2025 •
edited
Loading

Fixed! Can confirm that this evals with the documentation option set. The documentation build is failing for me, but it seems unrelated to hosts.

@toastal
Copy link
Contributor

toastal commented Mar 27, 2025

Oh, I have seen issues with literalExpressions too. It’s hard to understand what is going on.

@benjamb
Copy link

benjamb commented Mar 27, 2025

Ah, so it was the addition of defaultText that fixed it in my branch. Thanks for the fix!

benjamb
benjamb approved these changes Mar 27, 2025
View reviewed changes
Copy link

@benjamb benjamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the build for me with documentation.nixos.includeAllModules enabled.

@benjamb benjamb mentioned this pull request Mar 27, 2025
Closed
@Pandapip1
Copy link
Contributor Author

Pandapip1 commented Mar 27, 2025 •
edited
Loading

Oh, I have seen issues with literalExpressions too. It’s hard to understand what is going on.

To my understanding, the issue is that when the markup for the option is being created, it can't depend on the value of certain things; config is one of them. I personally haven't seen any situations in which literalExpressions causes an issue / an issue persists with it set. It would be helpful to see an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toastal toastal toastal approved these changes

@benjamb benjamb benjamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nix flake: error: attribute 'enableIPv6' missing
3 participants
@Pandapip1 @toastal @benjamb