[automodel] model_accelerator -> te_config #12895
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
akoumpa
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| from nemo.lightning.pytorch.accelerate.transformer_engine import te_accelerate | ||
| from nemo.automodel.accelerator.transformer_engine import te_accelerate |
Check notice
Code scanning / CodeQL
Unused import Note test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 5 days ago
To fix the problem, we need to remove the unused import statement. This will clean up the code and eliminate the unnecessary dependency. Specifically, we will remove the line from nemo.automodel.accelerator.transformer_engine import te_accelerate from the file tests/collections/llm/hf/pretrain.py.
Suggested changeset
1
tests/collections/llm/hf/pretrain.py
| @@ -95,3 +95,3 @@ | ||
|
|
||
| from nemo.automodel.accelerator.transformer_engine import te_accelerate | ||
|
|
||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
torsli
reviewed
Apr 4, 2025
| @@ -30,23 +30,28 @@ class TEConfig: | |||
| - fp8_autocast (bool): indicated whether to autocast to FP8 or not. | |||
There was a problem hiding this comment.
nit: add insert_te_modules to docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Moves the code out of nemo/lightning/ and into nemo/automodel/accelerator and changes model_accelerator to te_config.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information