Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue with prompts #12892

Merged
merged 1 commit into from
Apr 8, 2025
Merged

fixed issue with prompts #12892

merged 1 commit into from
Apr 8, 2025

Conversation

Ssofja
Copy link
Collaborator

@Ssofja Ssofja commented Apr 4, 2025

What does this PR do ?

Fixed an issue connected with canary promts in Multi_Task_Adapters.ipynb
Collection: asr

Changelog

  • Changed dataset class in Multi_Task_Adapters tutorial to update prompts by using new CanaryPromptFormatter

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

@github-actions github-actions bot added the ASR label Apr 4, 2025
@Ssofja Ssofja requested review from pzelasko and nithinraok and removed request for pzelasko April 4, 2025 21:43
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Apr 6, 2025
Copy link
Collaborator

@nithinraok nithinraok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ssofja <sofiakostandian@gmail.com>
@Ssofja Ssofja force-pushed the multitask_adapters_prompts_fix branch from d519c55 to 0a6e34f Compare April 7, 2025 14:09
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Apr 7, 2025
@Ssofja Ssofja enabled auto-merge (squash) April 7, 2025 14:59
@Ssofja Ssofja disabled auto-merge April 7, 2025 18:22
@github-actions github-actions bot removed the Run CICD label Apr 8, 2025
Copy link
Contributor

github-actions bot commented Apr 8, 2025

[🤖]: Hi @Ssofja 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@nithinraok nithinraok merged commit 393d6e2 into main Apr 8, 2025
241 checks passed
@nithinraok nithinraok deleted the multitask_adapters_prompts_fix branch April 8, 2025 02:47
jomitchellnv pushed a commit to jomitchellnv/NeMo that referenced this pull request Apr 8, 2025
Signed-off-by: Ssofja <sofiakostandian@gmail.com>
Signed-off-by: Jonathan Mitchell <jomitchell@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants