[CSSGapDecorations] Add pseudo-element alternative #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alisonmaher @bfgeek I feel like there's another dimension of complexity with the pseudo-element approach that I'm not quite putting my finger on, could you ptal and leave a suggestion if you have one? |
alisonmaher
approved these changes
Mar 26, 2025
| rows and columns depending on their contents. That means we don't know until | ||
| layout time how many such pseudo styles we need to produce, which creates a | ||
| wrong-way dependency between layout and style. It would also mean that, for | ||
| large containers, we would incur the costs of calculating styles for every |
There was a problem hiding this comment.
I think the other point here was that we would need objects for all the gaps (which I guess could be implied by the need to calculate styles for every gap)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.