Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable tab completion of kwargs for large method tables #58012

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mbauman
Copy link
Member

@mbauman mbauman commented Apr 4, 2025

while testing to ensure that absurdly large method tables don't tank the performance of the REPL

Fixes #57836

while testing to ensure that absurdly large method tables don't tank
the performance of the REPL
@mbauman mbauman added REPL Julia's REPL (Read Eval Print Loop) completions Tab and autocompletion in the repl labels Apr 4, 2025
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're just essentially demonstrating here that for your specific test case, the subtyping algorithm always takes the fast path--which is true, but seems hardly relevant to the actual point of having this limit

@mbauman
Copy link
Member Author

mbauman commented Apr 4, 2025

I don't understand. These tests are effectively for both this change and #54131. Prior to those patches they fail.

I considered using the show MWE from #57836 but it seemed to be bad mojo to effectively test that the number of show methods was under some limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completions Tab and autocompletion in the repl REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REPL] Autocompletion of kwargs for some common functions no longer works
2 participants