Backports for 1.12.0-beta2 #58009
Open
Backports for 1.12.0-beta2 #58009
+53
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the sysimage more resistant to method invalidation, when defining a new `Integer` subtype with a right bitshift method. (cherry picked from commit 69a22cf)
… defined) (#57925) Fixes a discrepancy between the code in C before #57230 and in Julia afterwards, making sure to sequence these method definitions correctly. Not sure how to write a reliable test since it is specific to when this generated function is defined relative to the helpers used by this thunk, but the issue/fix is visible with: ``` $ ./julia -e 'code_lowered(ntuple, (Returns{Nothing}, Val{1000000}))' ``` Fix #57301 (cherry picked from commit a3c48d7)
Without this change `prevpow` and `nextpow` fail for, e.g., `BigInt`; incorrectly throwing a `MethodError`. For example, calls like `prevpow(3, big"10")` or `nextpow(3, big"10")` fail. The issue is that the code incorrectly assumes the existence of a `typemax` method. Another issue was a missing promote for the arguments of a `mul_with_overflow` call. Fixes #57906 (cherry picked from commit 3627a85)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported PRs:
append_c_digits: typeassertIntto improve inference #57950string(which is not always defined) #57925nextpow,prevpowfor types withouttypemax#49669Need manual backport:
reinit_ccallable#56987setglobal!#57896_precompilepkgs: interactive progress display: fix unintended capture #57932Core._svec_ref#57973Contains multiple commits, manual intervention needed:
Compiler:abstract_eval_invoke_inst: type assertExpr#57860Compiler:walk_to_defs,collect_leaves: specialize forpredecessors#57859Random:showmethod forMersenneTwister: invalidation resistance #57913eachregion(::AnnotatedString)implementation toBase#57912Base: shell escaping: inference improvement to prevent invalidation #57915Non-merged PRs with backport label:
@nospecializeforstring_index_err#57604maxthreadidfromThreads#57490