Add allow_partial parameter to the "coins to spend" query #2912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AurelienFT
requested review from
a team,
xgreenx,
Dentosal,
MitchTurner and
netrome
as code owners
3 tasks
xgreenx
previously approved these changes
Mar 31, 2025
MitchTurner
reviewed
Apr 1, 2025
Co-authored-by: Mitchell Turner <james.mitchell.turner@gmail.com>
Co-authored-by: Mitchell Turner <james.mitchell.turner@gmail.com>
MitchTurner
previously approved these changes
Apr 1, 2025
xgreenx
requested changes
Apr 1, 2025
|
@xgreenx all the cases should be covered now. |
xgreenx
reviewed
Apr 4, 2025
crates/fuel-core/src/coins_query.rs
Outdated
| @@ -277,12 +287,12 @@ pub async fn select_coins_to_spend( | |||
| let (selected_big_coins_total, selected_big_coins) = | |||
| big_coins(big_coins_stream, adjusted_total, max, exclude).await?; | |||
|
|
|||
| if selected_big_coins_total < total { | |||
| if selected_big_coins_total < total && !allow_partial { | |||
There was a problem hiding this comment.
I think if selected_big_coins_total is zero we still should return an error
There was a problem hiding this comment.
Done and also modified in the other function
xgreenx
reviewed
Apr 4, 2025
| @@ -709,6 +720,70 @@ mod tests { | |||
| let (owner, asset_ids, base_asset_id, db) = setup_coins_and_messages(); | |||
| multiple_assets_helper(owner, &asset_ids, &base_asset_id, db).await; | |||
| } | |||
|
|
|||
| mod allow_partial { | |||
There was a problem hiding this comment.
It also would be nice to add tests for the case when indexation is available
There was a problem hiding this comment.
I added the tests
xgreenx
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
Closes #2898
THIS IS A REVIVAL OF #2904 WITH REVIEW COMMENTS ADDRESSED (because of CLA). Inspiration from Rafal. Kudos to @rafal-ch !
Description
This PR introduces the new allow_partial parameter to the "coins to spend" inputs query. This field is optional to avoid breaking change. If set to true, the query returns available coins instead of failing when the requested amount is unavailable.
I consider this change "non-breaking" since the new parameter is not strictly required when sending the query.
Checklist
Before requesting review