-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support UDF in plan generator #3040
base: main
Are you sure you want to change the base?
Conversation
This reverts commit 3a5a44b.
Result of fdb-record-layer-pr on Linux CentOS 7
|
Result of fdb-record-layer-pr on Linux CentOS 7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am putting @alecgrieser on this review as well to make sure the proto layout and dependencies are what we want. I left a bunch of comments. There is some more work required but it's on the right track. I would recommend not ever removing -Werror
(not even in your local build). It is useful. Also, please make sure the PR runs through the PRB.
fdb-record-layer-core/src/main/java/com/apple/foundationdb/record/RecordMetaData.java
Outdated
Show resolved
Hide resolved
...rd-layer-core/src/main/java/com/apple/foundationdb/record/metadata/ScalarValuedFunction.java
Outdated
Show resolved
Hide resolved
...rd-layer-core/src/main/java/com/apple/foundationdb/record/metadata/ScalarValuedFunction.java
Outdated
Show resolved
Hide resolved
...ord-layer-core/src/main/java/com/apple/foundationdb/record/query/plan/cascades/Function.java
Outdated
Show resolved
Hide resolved
...ayer-core/src/main/java/com/apple/foundationdb/record/query/plan/cascades/MacroFunction.java
Outdated
Show resolved
Hide resolved
...in/java/com/apple/foundationdb/record/query/plan/cascades/KeyExpressionExpansionVisitor.java
Outdated
Show resolved
Hide resolved
...rd-layer-core/src/main/java/com/apple/foundationdb/record/metadata/ScalarValuedFunction.java
Outdated
Show resolved
Hide resolved
fdb-record-layer-core/src/main/java/com/apple/foundationdb/record/metadata/Key.java
Outdated
Show resolved
Hide resolved
fdb-record-layer-core/src/main/java/com/apple/foundationdb/record/RecordMetaData.java
Outdated
Show resolved
Hide resolved
Result of fdb-record-layer-pr on Linux CentOS 7
|
No description provided.