Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added search option on all challenges and hosted challenges #4465

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Akshat453
Copy link
Contributor

Fix #3701

Screenshot 2025-03-07 at 12 16 24 AM

Copy link
Member

@gautamjajoo gautamjajoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check why the build is failing? Also, I see a couple of css changes as well. Are they necessary?

@RishabhJain2018
Copy link
Member

@Akshat453 Any updates in the comments?

Copy link

codecov bot commented Mar 22, 2025

Codecov Report

Attention: Patch coverage is 60.71429% with 22 lines in your changes missing coverage. Please review.

Project coverage is 69.13%. Comparing base (96968d6) to head (5075fb4).
Report is 1123 commits behind head on master.

Files with missing lines Patch % Lines
frontend/src/js/controllers/challengeListCtrl.js 48.64% 19 Missing ⚠️
frontend/src/js/controllers/hostedChallengeCtrl.js 84.21% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4465      +/-   ##
==========================================
- Coverage   72.93%   69.13%   -3.80%     
==========================================
  Files          83       20      -63     
  Lines        5368     3626    -1742     
==========================================
- Hits         3915     2507    -1408     
+ Misses       1453     1119     -334     
Files with missing lines Coverage Δ
frontend/src/js/controllers/hostedChallengeCtrl.js 94.64% <84.21%> (-5.36%) ⬇️
frontend/src/js/controllers/challengeListCtrl.js 77.22% <48.64%> (-17.46%) ⬇️

... and 64 files with indirect coverage changes

Files with missing lines Coverage Δ
frontend/src/js/controllers/hostedChallengeCtrl.js 94.64% <84.21%> (-5.36%) ⬇️
frontend/src/js/controllers/challengeListCtrl.js 77.22% <48.64%> (-17.46%) ⬇️

... and 64 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523e894...5075fb4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Akshat453
Copy link
Contributor Author

@Akshat453 Any updates in the comments?

yes i have fixed the build i am working on the changes in the search bar

@Akshat453
Copy link
Contributor Author

Akshat453 commented Mar 23, 2025

Hello @RishabhJain2018 @gautamjajoo could you please review this?

Changes in the latest Commit

Fixes Issue:#3898
Following up on PR :#4362

Changes Implemented:

  • Searchbar
  • Domain filter
  • Filter by Host Team
  • Sort in ascending or descending alphabetical order
  • Sort by Start date and End date

Screenshot 2025-03-24 at 12 05 48 AM

Video Demonstration:

  • Searchbar
  • Domain filter
  • Filter by Host Team
  • Sort in ascending or descending alphabetical order
Screen.Recording.2025-03-24.at.12.14.36.AM.2.mov

When we select Filter by Host Team, the sorting option disappears since it is no longer necessary
I have added dummy data in Host Team to demonstrate the functionality (not included in the PR)

  • Sort by Start date and End date
Screen.Recording.2025-03-24.at.12.17.07.AM.1.mov

Copy link
Member

@gautamjajoo gautamjajoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality is great, but the UI needs improvement. Would adding a collapsible menu for filters enhance the experience?

@Akshat453
Copy link
Contributor Author

Yes I'll work on the changes and let you know once they're complete

@Akshat453
Copy link
Contributor Author

Akshat453 commented Mar 28, 2025

Hey @gautamjajoo Are you suggesting something like this?

Screenshot 2025-03-28 at 9 52 18 AM

Implementing a dedicated sorting tab and a filter tab, similar to Flipkart’s design, could enhance the user experience. It would provide a cleaner and more intuitive interface while keeping the filtering options accessible.

Screenshot 2025-03-28 at 9 51 59 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FrontendV2] Add search option on all challenges and hosted challenges page
3 participants