-
-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added search option on all challenges and hosted challenges #4465
base: master
Are you sure you want to change the base?
Conversation
Cloud-CV#4456)" This reverts commit 523e894. Change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check why the build is failing? Also, I see a couple of css changes as well. Are they necessary?
@Akshat453 Any updates in the comments? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4465 +/- ##
==========================================
- Coverage 72.93% 69.13% -3.80%
==========================================
Files 83 20 -63
Lines 5368 3626 -1742
==========================================
- Hits 3915 2507 -1408
+ Misses 1453 1119 -334
... and 64 files with indirect coverage changes
... and 64 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
yes i have fixed the build i am working on the changes in the search bar |
Hello @RishabhJain2018 @gautamjajoo could you please review this? Changes in the latest CommitFixes Issue:#3898 Changes Implemented:
Video Demonstration:
Screen.Recording.2025-03-24.at.12.14.36.AM.2.movWhen we select Filter by Host Team, the sorting option disappears since it is no longer necessary
Screen.Recording.2025-03-24.at.12.17.07.AM.1.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functionality is great, but the UI needs improvement. Would adding a collapsible menu for filters enhance the experience?
Yes I'll work on the changes and let you know once they're complete |
Hey @gautamjajoo Are you suggesting something like this? Implementing a dedicated sorting tab and a filter tab, similar to Flipkart’s design, could enhance the user experience. It would provide a cleaner and more intuitive interface while keeping the filtering options accessible. |
Fix #3701