Skip to content

Commit 3fa3e37

Browse files
committed
api: Don't allow connecting to servers <5.0; show nag banner on <7.0
See 8552afc for the previous one of these. The Zulip Server 5 release went out over 3 years ago, so the 4.x releases are all long out of our announced 18-month compatibility window: https://blog.zulip.com/2022/03/29/zulip-5-0-released/ https://zulip.readthedocs.io/en/latest/overview/release-lifecycle.html#client-apps So we can cheerfully refuse to connect to 4.x releases; our "Server not supported" nag banner has been asking server admins on those versions to upgrade since 8552afc, which the changelog says went out in v27.216, dated 2023-10-10. The last 6.x release, 6.2, went out on 2023-05-19. That's also outside the 18-month window, so it's time to start showing the nag banner on those servers. The last 7.x release, 7.5, went out on 2023-11-16, which is a month and a bit shy of 18 months, so it's not yet time to show the banner for versions 7.x.
1 parent 4d9d46d commit 3fa3e37

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/api/apiErrors.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ export const interpretApiResponse = (httpStatus: number, data: mixed): mixed =>
182182
*/
183183
// This should lag a bit behind the threshold version for ServerCompatBanner
184184
// (kMinSupportedVersion), to give users time to see and act on the banner.
185-
export const kMinAllowedServerVersion: ZulipVersion = new ZulipVersion('4.0');
185+
export const kMinAllowedServerVersion: ZulipVersion = new ZulipVersion('5.0');
186186

187187
/**
188188
* An error we throw in API bindings on finding a server is too old.

src/common/ServerCompatBanner.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@ export const kServerSupportDocUrl: URL = new URL(
3232
* See also kMinAllowedServerVersion in apiErrors.js, for the version below
3333
* which we just refuse to connect.
3434
*/
35-
export const kMinSupportedVersion: ZulipVersion = new ZulipVersion('5.0');
35+
export const kMinSupportedVersion: ZulipVersion = new ZulipVersion('6.0');
3636

3737
/**
3838
* The next value we'll give to kMinSupportedVersion in the future.
3939
*
4040
* This should be the next major Zulip Server version after kMinSupportedVersion.
4141
*/
42-
export const kNextMinSupportedVersion: ZulipVersion = new ZulipVersion('6.0');
42+
export const kNextMinSupportedVersion: ZulipVersion = new ZulipVersion('7.0');
4343

4444
type Props = $ReadOnly<{||}>;
4545

0 commit comments

Comments
 (0)