is_principal_with_data is broken for fractional ideals of non-maximal orders

[timovelten]

Calling is_principal_with_data with a fractional ideal (of non maximal orders of number fields) does not work, as it is currently implemented in terms of the non-existent function is_principal_non_maximal.

Running the following code

_, x = QQ[:x]
O = equation_order(x^5 - 5)
is_principal_with_data(fractional_ideal(O, [one(number_field(O))]))

results in the error

ERROR: UndefVarError: `is_principal_non_maximal` not defined in `Hecke`
Suggestion: check for spelling errors or missing imports.
Stacktrace:
 [1] is_principal_with_data(A::AbsSimpleNumFieldOrderFractionalIdeal)
   @ Hecke ~/.julia/packages/Hecke/G43QZ/src/NumFieldOrd/NfOrd/Clgp/Map.jl:528
 [2] top-level scope
   @ REPL[6]:1

[thofma]

Thanks for the report. I think for this specific example O is maximal, but I can reproduce the error using a non-maximal order. I will look into it.

[timovelten]

Sorry, I meant to use x^2 - 5 as an example. I don't know how that typo got in there.

[thofma]

Will be fixed in #1834