Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] building a systematic test suite for models #1771

Open
fkiraly opened this issue Feb 20, 2025 · 0 comments
Open

[ENH] building a systematic test suite for models #1771

fkiraly opened this issue Feb 20, 2025 · 0 comments
Labels
enhancement New feature or request maintenance Continuous integration, unit testing & package distribution

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Feb 20, 2025

We should build a systematic test suite for models.

Currently, there are tests per model.

A "test suite" means something like TestAllForecasters in sktime, where we loop over forecasters, but with the contract of pytorch-forecasting.

The test suite should cover basic usage vignettes, including those shown in the tutorials.

Architecturally, I suggest using scikit-base as a soft dependency (testing depset only), to index and collect all forecasters, and to build the test framework.

While this is probably not a good first issue, we should collect code snippets that should work for all foercaster classes, for inclusion in the test suite.

@fkiraly fkiraly added enhancement New feature or request maintenance Continuous integration, unit testing & package distribution labels Feb 20, 2025
fkiraly added a commit that referenced this issue Feb 22, 2025
This PR moves the model base classes into the `modeles.base` module,
which is a folder module with private submodules.

This is a pure refactor, preparing for a `base` module with more files -
for instance, towards
#1771.

Part 1 of 2, part 2 in
#1774, separate in
order to ensure that files are properly tracked as renamed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

No branches or pull requests

1 participant