Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue][Keras 3 OpenVINO Backend]: Support numpy.log1p operation #29487

Open
rkazants opened this issue Mar 15, 2025 · 12 comments · May be fixed by keras-team/keras#21050
Open

[Good First Issue][Keras 3 OpenVINO Backend]: Support numpy.log1p operation #29487

rkazants opened this issue Mar 15, 2025 · 12 comments · May be fixed by keras-team/keras#21050
Assignees
Labels
good first issue Good for newcomers Keras 3 OpenVINO Backend Keras 3 OpenVINO Backend no_stale Do not mark as stale

Comments

@rkazants
Copy link
Member

Context

🚀**A great opportunity to contribute to two popular AI projects with just one PR:: Keras 3 and OpenVINO.**🚀

Keras 3 enables seamless switching between supported backends—PyTorch, TensorFlow, and JAX—for both training and inference of traditional models and LLMs/GenAI pipelines. Since Keras 3.8.0, we've introduced a preview version of the OpenVINO backend (for inference only), allowing developers to leverage OpenVINO for model predictions directly within Keras 3 workflows. Activating the OpenVINO backend requires just one line of code to run inference on Keras 3-trained models. Here’s an example for a BERT model from Keras Hub:

import os
os.environ["KERAS_BACKEND"] = "openvino"
import numpy as np
import keras
import keras_hub

features = {
    "token_ids": np.ones(shape=(2, 12), dtype="int32"),
    "segment_ids": np.array([[0, 0, 0, 0, 0, 1, 1, 1, 1, 1, 0, 0]] * 2),
    "padding_mask": np.array([[1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 0, 0]] * 2),
}

classifier = keras_hub.models.BertTextClassifier.from_preset("bert_base_en_uncased", num_classes=4, preprocessor=None)
output = classifier.predict(features)

Currently, the OpenVINO backend lacks support for some operations. Our goal is to resolve this gap and to optimize it for inference on Intel devices—including CPUs, integrated GPUs, discrete GPUs, and NPUs—by supporting as many models as possible while delivering optimal performance. We aim to make the OpenVINO backend the No. 1 choice for model inference within the Keras 3 workflow.

What needs to be done?

Steps to Contribute

  1. Set up your developer environment:
  • fork and clone keras repo
  • install requirements for OpenVINO backend development pip install -r requirements-openvino.txt. The requirements file can be found in the root directory of cloned repository
  1. Provide decomposition in Python for numpy.log1p using OpenVINO opset

  2. Include tests by removing line corresponding to the implemented operation in excluded_concrete_tests.txt file.

  3. Make sure that tests are passing

  • create pytest.ini file and place it in the root directory of the clone repository. This file should contain the following content:
[pytest]
env =
    KERAS_BACKEND=openvino
  • run tests pytest-c ./pytest.ini ./keras/src/ops/numpy_test.py
  1. Commit your changes and create PR in keras repository. Mention @rkazants in PR description for review.

Below is an exemplar PR of how support for numpy.amax has been implemented.

Example Pull Requests

Resources

Contact points

@rkazants

Ticket

No response

@darshil929
Copy link

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@Sachin-NK
Copy link

still open to work ?

@chiruu12
Copy link

@rkazants Sir will it be fine if I take on this issue too?

@Raghavyadav17
Copy link

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@Raghavyadav17
Copy link

hi @rkazants, hope you're doing well, I was running into a small issue while installing the dependencies for openvino backend dev, I get this error

ERROR: Could not find a version that satisfies the requirement torch-xla==2.6.0 (from versions: none) ERROR: No matching distribution found for torch-xla==2.6.0

This is because of the compatibility issues of torch-xla with windows. So do I just skip the torch-Xla installation by commenting out torch-xla==2.6.0;sys_platform != 'darwin' in the .txt file or do I install a different version of torch-xla ??

Clarification on this would be appreciated !!!! Thanks...

@rkazants
Copy link
Member Author

hi @rkazants, hope you're doing well, I was running into a small issue while installing the dependencies for openvino backend dev, I get this error

ERROR: Could not find a version that satisfies the requirement torch-xla==2.6.0 (from versions: none) ERROR: No matching distribution found for torch-xla==2.6.0

This is because of the compatibility issues of torch-xla with windows. So do I just skip the torch-Xla installation by commenting out torch-xla==2.6.0;sys_platform != 'darwin' in the .txt file or do I install a different version of torch-xla ??

Clarification on this would be appreciated !!!! Thanks...

Just ignore this dependency, it is not needed for development of OV backend in keras

@Raghavyadav17
Copy link

sure will do so, thanks !!! Will create a PR for this issue soon..

@mlukasze mlukasze moved this from Contributors Needed to In Review in Good first issues Mar 24, 2025
@rkazants rkazants moved this from In Review to Contributors Needed in Good first issues Apr 3, 2025
@victorgearhead
Copy link

.take

Copy link
Contributor

github-actions bot commented Apr 3, 2025

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@p-wysocki p-wysocki moved this from Contributors Needed to Assigned in Good first issues Apr 4, 2025
@victorgearhead
Copy link

@rkazants can you please check the PR and advise me about the pre-commit issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Keras 3 OpenVINO Backend Keras 3 OpenVINO Backend no_stale Do not mark as stale
Projects
Status: Assigned
Development

Successfully merging a pull request may close this issue.

6 participants