Should ofCubeMapsData() & ofShadowsData() be private? documentation missing

[danomatika]

With of_v20250330_osx_release:

Is ofCubeMapsData() something public or really only needed internally for ofCubeMap and ofMaterial? There is no comment to explain its usage and the naming is ambiguous to me.

There is really a dearth of commenting on this class other than the load functions. Sorry if this is a graphics pattern which I should recognize, however I don't think we should assume that for stuff in the core.

[danomatika]

If this is indeed something internal, maybe it can be hidden somehow as a friend function, within of::priv, etc.

[danomatika]

The same holds true for ofShadowsData() in ofShadow.h.

[NickHardeman]

ofCubeMapsData() and ofShadowsData() is replicating the ofLightsData() method here:

openFrameworks/libs/openFrameworks/gl/ofLight.h

Line 128 in 090ffe7

std::vector<std::weak_ptr<ofLight::Data> > & ofLightsData();

Useful for storing the data about all the cube maps and shadows that have been created, mostly for internal use. A user could find this useful for passing the information to their own shaders but seems unlikely.
Documentation comments would be helpful throughout the entire ofCubeMap and ofShadow classes.