Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HANDS-ON BUG] 2.3 LangGraph: The code in the notebook is not the same as in course page #350

Open
ivanignatiev opened this issue Mar 20, 2025 · 2 comments

Comments

@ivanignatiev
Copy link
Contributor

Describe the bug

Code present in https://huggingface.co/learn/agents-course/unit2/langgraph/first_graph is not the same as in notebook https://huggingface.co/agents-course/notebooks/blob/main/unit2/langgraph/mail_sorting.ipynb

For example, email_category is missing in Step 2

To Reproduce

Compare code blocks in https://huggingface.co/learn/agents-course/unit2/langgraph/first_graph and https://huggingface.co/agents-course/notebooks/blob/main/unit2/langgraph/mail_sorting.ipynb

Additional context

LangGraph unit.

@smagara
Copy link
Contributor

smagara commented Mar 21, 2025

Seems to be missing the LangFuse Step #6 from this commit.

The mdx has this section as Step #6, but the Jupyter seems to have it as Step #5 and it didn't get deployed, if that's a clue...

Image

Image

@rsantosvisionlab
Copy link

Hello:

It is indeed different, code from web than colab or github.
an example:

  • in the web code, ,there is an issue with
    email_graph.add_edge("draft_response", "notify_mr_hugg")

you get an error: ValueError: 'draft_response' is already being used as a state key.

´draft_response´ should be replace in some places by something different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants